Skip to content

DPL: add support for writing general Metadata to AO2D#15553

Open
ktf wants to merge 2 commits into
AliceO2Group:devfrom
ktf:pr15553
Open

DPL: add support for writing general Metadata to AO2D#15553
ktf wants to merge 2 commits into
AliceO2Group:devfrom
ktf:pr15553

Conversation

@ktf

@ktf ktf commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

No description provided.

@ktf ktf requested a review from a team as a code owner June 24, 2026 13:04
@ktf

ktf commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

@shahor02 would something like this work for you?

@shahor02

shahor02 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Probably, will check next week in details. So, the data should be wrapper to TObject?

@ktf

ktf commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

this we can discuss. What I would like to avoid is that the collector needs to know about every single datatype of the configurables.

aalkin
aalkin reviewed Jun 29, 2026
View reviewed changes
Comment thread Framework/AnalysisSupport/src/AODWriterHelpers.cxx Outdated
@ktf @aalkin
Update Framework/AnalysisSupport/src/AODWriterHelpers.cxx
ac39a54 
Co-authored-by: Anton Alkin <anton.alkin@cern.ch>
@alibuild alibuild mentioned this pull request Jun 29, 2026
Open
@alibuild

alibuild commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for ac39a54 at 2026-06-29 14:07:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Framework/AnalysisSupport/src/AODWriterHelpers.cxx:503:41: error: no match for call to '(const std::ranges::__find_if_fn) (const std::shared_ptr<std::vector<std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> > > >&, o2::framework::writers::AODWriterHelpers::getMetadataCollector(const o2::framework::ConfigContext&)::<lambda(o2::framework::InitContext&)>::<lambda(o2::framework::ProcessingContext&)>::<lambda(const auto:59&)>)'
ninja: build stopped: subcommand failed.

Full log here.

aalkin
aalkin reviewed Jun 29, 2026
View reviewed changes
Comment thread Framework/AnalysisSupport/src/AODWriterHelpers.cxx
TObject* value = part->GetValue(key);
std::string k = key->GetName();
std::string v = value != nullptr ? value->GetName() : "";
auto it = std::ranges::find_if(merged,

@aalkin aalkin Jun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto it = std::ranges::find_if(merged,
auto it = std::ranges::find_if(*merged,

I apologize for missing that merged is a pointer, this should fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@aalkin aalkin aalkin left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ktf @shahor02 @alibuild @aalkin